Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cable Length under "Cables" concats length with the length_type id instead of name #2666

Closed
DanSheps opened this issue Dec 11, 2018 · 1 comment · Fixed by #2670
Closed

Cable Length under "Cables" concats length with the length_type id instead of name #2666

DanSheps opened this issue Dec 11, 2018 · 1 comment · Fixed by #2670
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@DanSheps
Copy link
Member

Environment

  • Python version: 3.6
  • NetBox version: 2.5

Steps to Reproduce

  • Create a cable connection with length and length_type specified (Ex. 6 "Inches"
  • View connection in Devices->Cables

Expected Behavior

Cable length defined as 6 Inches

Observed Behavior

Cable length is defined as 62000
@DanSheps
Copy link
Member Author

Working on a PR for this issue now.

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Dec 11, 2018
DanSheps added a commit to DanSheps/netbox that referenced this issue Dec 11, 2018
@DanSheps
Fixes netbox-community#2666: Uses correct function for displaying cho…
b4f79f1 
…ices label

 * Changes record.length_type to record.get_length_type_display
@DanSheps DanSheps mentioned this issue Dec 11, 2018
Merged
jeremystretch added a commit that referenced this issue Dec 11, 2018
@jeremystretch
Merge pull request #2670 from DanSheps/2666-fix-length-display
24d1707 
Fixes #2666: Uses correct function for displaying choices label
jeremystretch added a commit that referenced this issue Dec 11, 2018
@jeremystretch
Changelog for #2666
b8a4316
@jeremystretch jeremystretch mentioned this issue Dec 13, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2666: Uses correct function for displaying choices label DanSheps/netbox
2 participants
@DanSheps @jeremystretch