Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "White" as a cable color #2693

Closed
DanSheps opened this issue Dec 14, 2018 · 1 comment · Fixed by #2694
Closed

Add "White" as a cable color #2693

DanSheps opened this issue Dec 14, 2018 · 1 comment · Fixed by #2694
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@DanSheps
Copy link
Member

DanSheps commented Dec 14, 2018

Environment

  • Python version: 3.6
  • NetBox version: 2.5.1

Proposed Functionality

Add color white to the cable colors.

Optionally add:

  • slate(Dark Grey works, almost identical color)
  • rose
  • violet (Fuschia works, almost identical color)
  • aqua

Use Case

These fiber strand colors are missing

Database Changes

None

External Dependencies

None

DanSheps added a commit to DanSheps/netbox that referenced this issue Dec 14, 2018
@jeremystretch jeremystretch changed the title Add "White" as a cable color, Add "White" as a cable color Dec 14, 2018
@jeremystretch
Copy link
Member

I'm fine with adding white. Any additional colors will need to be compared to the existing list to ensure they are easily distinguished from all existing colors.

We'll also need to ensure that the proper foreground color is used. There's a utility function named foreground_color() which outputs the ideal foreground color (black or white) given an arbitrary background color. We can expose this as a template filter.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Dec 19, 2018
DanSheps added a commit to DanSheps/netbox that referenced this issue Jan 3, 2019
* Revert CSS Background Hack
jeremystretch added a commit that referenced this issue Jan 3, 2019
Closes #2693 - Adds additional colors for cables & roles
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants