Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rack_group missing from power feed add/view #3647

Closed
bellwood opened this issue Oct 28, 2019 · 4 comments
Closed

rack_group missing from power feed add/view #3647

bellwood opened this issue Oct 28, 2019 · 4 comments
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation

Comments

@bellwood
Copy link
Contributor

bellwood commented Oct 28, 2019

Environment

  • Python version: 3.6.9
  • NetBox version: 2.6.6

Steps to Reproduce

  1. Import a new power feed, fill all fields (including the rack_group)
  2. View the feed

Expected Behavior

Feed add/view should include rack_group

Observed Behavior

Feed add/view is missing rack_group

Additional Details

Pursuant to: 800df1e

Edit: Sorry for so many edits... Powerfeeds as a whole need to be reviewed to add in rack_group. It's also missing from the sidebar search, there's no heading for it when listing all power feeds, etc.

@bellwood bellwood changed the title rack_group missing from power feed view rack_group missing from power feed add/view Oct 28, 2019
@bellwood bellwood changed the title rack_group missing from power feed add/view rack_group missing from power feed view Oct 28, 2019
@bellwood bellwood changed the title rack_group missing from power feed view rack_group missing from power feed add/view Oct 28, 2019
@kobayashi
Copy link
Contributor

Power panel view shows Both Rack Group and Power Feeds. Is it not good?

Screenshot from 2019-11-02 03-27-16

@kobayashi kobayashi added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Nov 2, 2019
@bellwood
Copy link
Contributor Author

bellwood commented Nov 4, 2019

We've a lot of common naming in our IX unique to individual rack groups. Having to jump to a power panel just to see what rack_group its' in versus having it right with the rest of the data in view is sub-optimal from a work flow standpoint.

I suppose leaving it out of the tabular list of power feeds is OK if we can add filtering by rack_group in that view.

Edit: It would still be preferred to show the rack group on individual power feeds views as well.

@kobayashi
Copy link
Contributor

I would like to know more about your point. At power panel list view, you can search desired rack group and see the relation between rack group and power feed inside the searched power panel. Does this not fit your workflow?

If we would add rack_group to the page, we have to retrieve nested objects. This may effect for other pages now. This is because the list and search are included from shared template files which show related objects excluding nested for the display object.

@kobayashi
Copy link
Contributor

kobayashi commented Dec 5, 2019

@bellwood do you still have any comments for this? If you still have any questions or concerns about this issue, plz let me know to re-open.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation
Projects
None yet
Development

No branches or pull requests

2 participants