Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc error in custom_scripts #3697

Closed
candlerb opened this issue Nov 18, 2019 · 2 comments · Fixed by #3701
Closed

Doc error in custom_scripts #3697

candlerb opened this issue Nov 18, 2019 · 2 comments · Fixed by #3701
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation

Comments

@candlerb
Copy link
Contributor

candlerb commented Nov 18, 2019 •
edited

Change Type

[ ] Addition
[X] Correction
[ ] Deprecation
[ ] Cleanup (formatting, typos, etc.)

Proposed Changes

At this point is says there is a Meta attribute called field_order

But in the example it shows it as fields

One of these must be wrong. By experimentation, the correct attribute is field_order
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation labels Nov 18, 2019
@hSaria
Copy link
Contributor

hSaria commented Nov 20, 2019

@candlerb, are you gonna raise a PR for the correction or shall I?

@candlerb
Copy link
Contributor Author

Please go ahead.

@hSaria hSaria mentioned this issue Nov 20, 2019
Merged
jeremystretch added a commit that referenced this issue Nov 22, 2019
@jeremystretch
Merge pull request #3701 from hSaria/3697-custom-scripts-example-typo
6a451e0 
Fixes #3697: Correct field_order attribute name
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3697: Correct field_order attribute name
3 participants
@candlerb @jeremystretch @hSaria