Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LDAP authentication into a standalone authentication backend #4348

Closed
jeremystretch opened this issue Mar 11, 2020 · 5 comments · Fixed by #4713
Closed

Move LDAP authentication into a standalone authentication backend #4348

jeremystretch opened this issue Mar 11, 2020 · 5 comments · Fixed by #4713
Assignees
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone

Comments

@jeremystretch
Copy link
Member

Proposed Changes

With the introduction of support for custom authentication backends (#2328) in NetBox v2.8, it no longer makes sense to maintain LDAP authentication as part of NetBox's core.

Justification

Offloading this functionality removes the burden of maintenance from the core maintainers, encourages more community participation in the development of the LDAP backend itself, and should serve as a strong reference implementation for custom authentication backends. It will also help guide the development of remote authentication support in NetBox.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior labels Mar 11, 2020
@jeremystretch jeremystretch added this to the v2.9 milestone Mar 11, 2020
@bluikko
Copy link
Contributor

bluikko commented Apr 14, 2020

I'll repeat here that it would be nice if the LDAP module could also be used as an authorization module when external authentication is used. I don't know how doable/complex that would be.

After authentication is completed externally the user's group memberships are read from LDAP for permissions.

@jeremystretch
Copy link
Member Author

@bluikko That is beyond the scope of this issue.

@Haeki
Copy link

Haeki commented May 6, 2020

Since its possible to using an LDAP backend as custom authentication backend thats seems like a good idea.
A Problem could be if someone wants to use both ldap and another custom authentication backend. A possible solution would be to allow the use of more than one custom backend.

@Dimaqa
Copy link

Dimaqa commented Jul 20, 2020

I believe you need to add REMOTE_AUTH_CONFIG now, because there is no way to specify LDAP config other than in settings.py. Or am i missing something?

@sly-net
Copy link

sly-net commented Aug 14, 2020

I'll repeat here that it would be nice if the LDAP module could also be used as an authorization module when external authentication is used. I don't know how doable/complex that would be.

After authentication is completed externally the user's group memberships are read from LDAP for permissions.

@bluikko I've made a proof of concept of this. Check it out here: https://github.com/sly-net/netbox-remote-authn-ldap-authz

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants