Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API calls serving form fields are not using brief mode #6846

Closed
jeremystretch opened this issue Jul 29, 2021 · 0 comments
Closed

REST API calls serving form fields are not using brief mode #6846

jeremystretch opened this issue Jul 29, 2021 · 0 comments
Labels
beta Concerns a bug/feature in a beta release type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Jul 29, 2021

NetBox version

v3.0-beta1

Python version

3.7

Steps to Reproduce

  1. Open the browser's developer console to inspect HTTP requests
  2. Navigate to an interface and click the "connect" button
  3. When the next page loads, notice that all the REST API calls triggered by form fields do not append ?brief=True to the API URL

Expected Behavior

All form-triggered REST API calls should employ brief mode.

Observed Behavior

Brief mode is not being used.

IIRC we identified this issue previously and switched to brief mode, bud had temporarily reverted back to full mode because of #6773 (which has since been resolved). Edit: There's a TODO note in api.ts referencing missing _depth attributes in some nested serializers, but as far as I can tell they're all present.

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application beta Concerns a bug/feature in a beta release labels Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

1 participant