Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal values for cable lengths are not allowed in bulk edit #7090

Closed
jbakklund opened this issue Aug 31, 2021 · 1 comment · Fixed by #7105
Closed

Decimal values for cable lengths are not allowed in bulk edit #7090

jbakklund opened this issue Aug 31, 2021 · 1 comment · Fixed by #7105
Assignees
@sdktr
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jbakklund
Copy link

NetBox version

v3.0.0

Python version

3.7

Steps to Reproduce

  1. Navigate to .../dcim/cables/
  2. Mark a selection of cables and click on the "Edit Selected" button
  3. Set Length to for example, '1.5' and Length unit to 'Meters'

Expected Behavior

According to enhancement #6154, cable lengths should now allow decimal values.

Observed Behavior

NetBox responds with the following warning "Please enter a valid value. The two nearest valid values are 1 and 2."
@jbakklund jbakklund added the type: bug A confirmed report of unexpected behavior in the application label Aug 31, 2021
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Aug 31, 2021
@sdktr
Copy link
Contributor

sdktr commented Aug 31, 2021

CableModel specifies a Decimal:

netbox/netbox/dcim/models/cables.py

Line 77 in db29930

length = models.DecimalField(

The CableBulkEditForm specifies the Integer:

netbox/netbox/dcim/forms.py

Line 4589 in db29930

length = forms.IntegerField(

Can you assign this to me @jeremystretch so I can propose a PR?

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Aug 31, 2021
sdktr added a commit to sdktr/netbox that referenced this issue Aug 31, 2021
@sdktr
Fix netbox-community#7090: Cable Bulk Edit, length field should be de…
1909f0c 
…cimal
sdktr added a commit to sdktr/netbox that referenced this issue Aug 31, 2021
@sdktr
Changelog for netbox-community#7090
f1e4273
@jeremystretch jeremystretch mentioned this issue Aug 31, 2021
Merged
sdktr added a commit to sdktr/netbox that referenced this issue Aug 31, 2021
@sdktr
Changelog netbox-community#7090 fix whitespace
9c389d9
jeremystretch added a commit that referenced this issue Aug 31, 2021
@jeremystretch
Merge pull request #7105 from sdktr/7090-fix-cablebulkedit-length-field
515b6bf 
Fix #7090: cable bulk edit form - allow decimal input on length field
@jeremystretch jeremystretch mentioned this issue Sep 1, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sdktr sdktr

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7090: cable bulk edit form - allow decimal input on length field sdktr/netbox
3 participants
@jeremystretch @sdktr @jbakklund