Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter view for Locations is missing tags field #8357

Closed
dankotrajkovic opened this issue Jan 14, 2022 · 2 comments · Fixed by #8360
Closed

Filter view for Locations is missing tags field #8357

dankotrajkovic opened this issue Jan 14, 2022 · 2 comments · Fixed by #8360
Assignees
@jasonyates
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@dankotrajkovic
Copy link

dankotrajkovic commented Jan 14, 2022 •
edited by jeremystretch

NetBox version

v3.1.5

Python version

3.8

Steps to Reproduce

Navigate to Organization -> Locations.
e.g https://demo.netbox.dev/dcim/locations/
and then open the filters tab.

Expected Behavior

Under the first search field there should be a field for tags to compliment the Location model which was extended to include a tag field.

Observed Behavior

Other then the missing GUI field for tags, the filtering is working as expected in the background.
Verified by trying https://demo.netbox.dev/dcim/locations/?tag=my-tag
@dankotrajkovic dankotrajkovic added the type: bug A confirmed report of unexpected behavior in the application label Jan 14, 2022
@jeremystretch jeremystretch changed the title Filter view for Locations is missing TAG field Filter view for Locations is missing tags field Jan 14, 2022
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jan 14, 2022
jasonyates pushed a commit to jasonyates/netbox that referenced this issue Jan 14, 2022
Fixes netbox-community#8357 - Filter view for Locations is missing ta…
1ae5a2c 
…gs field

Adding tag field to Locations filter view
@jasonyates jasonyates mentioned this issue Jan 14, 2022
Merged
@jeremystretch
Copy link
Member

@jasonyates could you comment here so I can assign the issue to you (sine you already have a PR in)?

@jasonyates
Copy link

Submitted PR for this. Reviewed the other filter forms too and confirmed they all have the tags field available.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jan 14, 2022
jeremystretch added a commit that referenced this issue Jan 14, 2022
@jeremystretch
Merge pull request #8360 from jasonyates/8357-location-filter
5564664 
Fixes #8357 - Filter view for Locations is missing tags field
jeremystretch added a commit that referenced this issue Jan 14, 2022
@jeremystretch
Changelog for #8342, #8357
b0948ea
@jeremystretch jeremystretch mentioned this issue Jan 17, 2022
Merged
larsks pushed a commit to larsks/netbox that referenced this issue Mar 8, 2022
@larsks
Fixes netbox-community#8357 - Filter view for Locations is missing ta…
e63c9a5 
…gs field

Adding tag field to Locations filter view
larsks pushed a commit to larsks/netbox that referenced this issue Mar 8, 2022
@jeremystretch @larsks
Changelog for netbox-community#8342, netbox-community#8357
77c0f25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonyates jasonyates

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #8357 - Filter view for Locations is missing tags field jasonyates/netbox
3 participants
@jasonyates @jeremystretch @dankotrajkovic