Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a base FilterSet class for plugins #8453

Closed
Tracked by #8333
jeremystretch opened this issue Jan 25, 2022 · 1 comment
Closed
Tracked by #8333

Provide a base FilterSet class for plugins #8453

jeremystretch opened this issue Jan 25, 2022 · 1 comment
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation topic: plugins Relates to the plugins framework type: feature Introduction of new functionality to the application
Milestone
v3.2

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.1.6

Feature type

New functionality

Proposed functionality

Define a base FilterSet class for use by plugins. NetBox currently defines BaseFilterSet and PrimaryModelFilterSet classes, the later of which extends the former to include custom field and change logging support. We'll probably end up refactoring the existing classes to provide something analogous to the BaseModel class.

Use case

Enables plugins to leverage the advanced functionality provided by NetBox's core filterset classes without having to duplicate code.

Database changes

No response

External dependencies

No response
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: under review Further discussion is needed to determine this issue's scope and/or implementation topic: plugins Relates to the plugins framework labels Jan 25, 2022
@jeremystretch jeremystretch mentioned this issue Jan 25, 2022
Closed
13 tasks
@jeremystretch jeremystretch self-assigned this Jan 25, 2022
@jeremystretch
Copy link
Member Author

I've renamed PrimaryModelFilterSet to NetBoxModelFilterSet for use by plugins.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jan 27, 2022
@jeremystretch jeremystretch added this to the v3.2 milestone Jan 27, 2022
jeremystretch added a commit that referenced this issue Jan 27, 2022
@jeremystretch
Closes #8453: Rename PrimaryModelFilterSet to NetBoxModelFilterSet & …
083d1ac 
…expose for plugins
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation topic: plugins Relates to the plugins framework type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v3.2
Development

No branches or pull requests
1 participant
@jeremystretch