Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make view name resolution plugin-safe #8472

Closed
Tracked by #8333
jeremystretch opened this issue Jan 27, 2022 · 0 comments
Closed
Tracked by #8333

Make view name resolution plugin-safe #8472

jeremystretch opened this issue Jan 27, 2022 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation topic: plugins Relates to the plugins framework type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

There are several areas within NetBox where the automatic resolution of a view name from a model does not account for the possibility that the mode has been provided by a plugin. We can easily adjust these to support plugin models.

Justification

This change is necessary to fully support plugins as part of the initiatives tracked under #8333.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user topic: plugins Relates to the plugins framework labels Jan 27, 2022
@jeremystretch jeremystretch self-assigned this Jan 27, 2022
This was referenced Jan 27, 2022
Merged
Closed
jeremystretch added a commit that referenced this issue Jan 27, 2022
@jeremystretch
Merge pull request #8473 from netbox-community/6221-pluginviews
3a447d5 
Closes #8472: Make view name resolution plugin-safe
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation topic: plugins Relates to the plugins framework type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch