Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Bar Appears to To Be Wrong Color in Dark Mode #8820

Closed
dvigne opened this issue Mar 8, 2022 · 1 comment
Closed

Navigation Bar Appears to To Be Wrong Color in Dark Mode #8820

dvigne opened this issue Mar 8, 2022 · 1 comment
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@dvigne
Copy link
Contributor

dvigne commented Mar 8, 2022

NetBox version

v3.1.9

Python version

3.9

Steps to Reproduce

Upgrade to 3.1.9 or perform a fresh install of Netbox

Expected Behavior

Navigation has background color code #171b1d

Navigation Bar

new

Observed Behavior

Navigation bar appears to be adopting a different color as shown below (#ffffff8c)

Navigation Bar

old

@dvigne dvigne added the type: bug A confirmed report of unexpected behavior in the application label Mar 8, 2022
@dvigne
Copy link
Contributor Author

dvigne commented Mar 8, 2022

I believe this to be caused by commit 796c5d7 where $navbar-light-color was set to $navbar-dark-color but I couldn't find where $navbar-dark-color was defined anywhere. I ended up forking the project and fixing this by changing it back to the way that @thatmattlove had it previously using $darkest instead of $navbar-light-color.

If you would like to see the quick fix I made on my server, here is the link to the commit on my fork:
dvigne@d8aa37e

I'd be happy to open a quick PR if you'd like to pull this in. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

1 participant