Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit local configuration of Django LOGGING #990

Closed
ktims opened this issue Mar 23, 2017 · 1 comment
Closed

Permit local configuration of Django LOGGING #990

ktims opened this issue Mar 23, 2017 · 1 comment
Labels
type: feature Introduction of new functionality to the application

Comments

@ktims
Copy link

ktims commented Mar 23, 2017

It would be useful to permit local configuration of the Django LOGGING setting. Currently if custom LOGGING is desired, it must be configured in settings.py, but this is part of the distribution. Simple change, as the facility to import local settings is already there.

diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
index ae81d26..c1daf42 100644
--- a/netbox/netbox/settings.py
+++ b/netbox/netbox/settings.py
@@ -15,7 +15,7 @@ except ImportError:
 VERSION = '1.9.3'
 
 # Import local configuration
-for setting in ['ALLOWED_HOSTS', 'DATABASE', 'SECRET_KEY']:
+for setting in ['ALLOWED_HOSTS', 'DATABASE', 'SECRET_KEY', 'LOGGING']:
     try:
         globals()[setting] = getattr(configuration, setting)
     except AttributeError:
@jeremystretch
Copy link
Member

FYI the code above would make LOGGING a mandatory setting, which is not what we want.

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Mar 27, 2017
lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants