Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ENGINE to database config #12458

Merged
merged 3 commits into from
May 4, 2023
Merged

Adds ENGINE to database config #12458

merged 3 commits into from
May 4, 2023

Conversation

abhi1693
Copy link
Member

@abhi1693 abhi1693 commented May 3, 2023

Fixes: #11791

jeremystretch
jeremystretch requested changes May 4, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you annotate the ENGINE setting in the documentation as well please? We should include a note that it must be a PostgreSQL-compatible backend.

@jeremystretch
Copy link
Member

Thanks @abhi1693!

@jeremystretch jeremystretch merged commit 93b912c into develop May 4, 2023
8 checks passed
@jeremystretch jeremystretch deleted the feat/11791-db-parameter branch May 4, 2023 17:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch Awaiting requested review from jeremystretch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement DATABASE_ENGINE Configuration Parameter
2 participants
@abhi1693 @jeremystretch