12591 config params admin #12904
Merged
12591 config params admin #12904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO we should remove it from the admin: It can be confusing having the same functionality accessible in two places. |
jeremystretch
requested changes
Jun 15, 2023
|
All updated @jeremystretch - I noticed I forgot to add the restore command, so that is in there now. |
jeremystretch
requested changes
Jun 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12591
Adds standard list, add, edit views for ConfigRevisions so can mange them within NetBox UI instead of the admin. Did not add the bulk edit or import views as those did not seem to make any sense for ConfigRevision. Left the functionality within the Admin, not sure if we wanted to remove those right away.
Note: Kept in the one-line admin.py as without it will cause a circular import issue. Opened up #12919 to track as this would require more refactoring that is worth a separate ticket.