Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #13381: Enable plugins to register custom data backends #14095

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Closes #13381: Enable plugins to register custom data backends #14095

merged 6 commits into from
Oct 24, 2023

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Oct 20, 2023 •
edited
Loading

Fixes: #13381

  • Move base DataBackend class from core to netbox
  • Remove static choices for DataSource.type
  • Validate DataSource.type against registered backends
  • Move register_backend() wrapper to core.utils
  • Introduce get_data_backend_choices() utility function
  • Add a data_backends attribute to PluginConfig
  • Establish name, label, and is_local attributes on DataBackend
  • Remove colors from DataSource types

@jeremystretch jeremystretch changed the title Initial work on #13381 Closes #13381: Enable plugins to register custom data backends Oct 20, 2023
@jeremystretch jeremystretch added beta Concerns a bug/feature in a beta release and removed beta Concerns a bug/feature in a beta release labels Oct 20, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Oct 23, 2023
@jeremystretch jeremystretch marked this pull request as ready for review October 23, 2023 20:07
arthanson
arthanson requested changes Oct 23, 2023
View reviewed changes
netbox/core/tests/test_views.py Outdated Show resolved Hide resolved
netbox/core/utils.py Outdated Show resolved Hide resolved
@jeremystretch jeremystretch merged commit 30ce9ed into feature Oct 24, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 13381-register-data-backends branch October 24, 2023 15:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arthanson arthanson arthanson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeremystretch @arthanson