Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds device and vm to service filter form #14215

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Adds device and vm to service filter form #14215

merged 2 commits into from
Nov 9, 2023

Conversation

abhi1693
Copy link
Member

@abhi1693 abhi1693 commented Nov 8, 2023

Fixes: #13951

jeremystretch
jeremystretch approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhi1693!

@jeremystretch jeremystretch merged commit 95519b4 into develop Nov 9, 2023
8 checks passed
@jeremystretch jeremystretch deleted the feat/13951-service-filter-form branch November 9, 2023 14:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add device_id and virtual_machine_id to ipam.forms.filtersets.ServiceFilterForm
2 participants
@abhi1693 @jeremystretch