Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15815 convert dashboard widgets for users/groups #15839

Merged
merged 4 commits into from May 1, 2024
Merged

15815 convert dashboard widgets for users/groups #15839

merged 4 commits into from May 1, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #15815

Convert dashboard widgets using users.netboxuser -> users.user and users.netboxgroup -> users.group

@arthanson arthanson marked this pull request as ready for review April 24, 2024 20:52
@arthanson arthanson added the beta Concerns a bug/feature in a beta release label Apr 24, 2024
jeremystretch
jeremystretch requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we should also take this opportunity to improve error handling in extras.dashboard.widgets.get_models_from_content_types(). IMO it's reasonably to fail silently when attempting to resolve a content type that doesn't exist.

netbox/extras/migrations/0115_convert_dashboard_widgets.py Outdated Show resolved Hide resolved
netbox/extras/migrations/0115_convert_dashboard_widgets.py Outdated Show resolved Hide resolved
jeremystretch
jeremystretch approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit 209f596 into feature May 1, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 15815-dashboard-widget branch May 1, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arthanson @jeremystretch