Feature 15492 - Copying of Admin->Authentication->Permissions #15976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CloningUserMixin to ObjectPermission to enable clone_fields.
jeremystretch
requested changes
May 7, 2024
netbox/users/models/features.py
Outdated
Comment on lines
10
to
12
| Provides the clone() method used to prepare a copy of existing objects. | ||
| The same code from netbox/users/models/features.py (CloningMixin) is used here. | ||
| It was necessary to avoid circular imports. |
There was a problem hiding this comment.
It's not acceptable to duplicate code from other modules, as this poses serious challenges to long-term maintainability. If employing the original mixin class results in a circular dependency, some other solution must be identified.
There was a problem hiding this comment.
One solution would be to create a "clone" method in the ObjectPermission and remove support for "tags" and "custom_fields" (they do not exist on the Users module).
I tried some solutions to avoid duplicate code, but they did not work.
I tested removing "from .permissions import *" from "init.py" and it showed promise, however this impacts several other files and I believe this solution is not viable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15492
It was created a copy of CloningMixin in users/features.py and used it in the ObjectPermission.