Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14948 add has_virtual_device_contexts filter to device #16209

Merged
merged 3 commits into from
May 22, 2024
Merged

14948 add has_virtual_device_contexts filter to device #16209

merged 3 commits into from
May 22, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #14948

Adds a has_virtual_device_contexts filter to devices.

Monosnap Devices | NetBox 2024-05-20 13-45-04

@arthanson arthanson changed the title DRAFT: 14948 add has_virtual_device_cnotexts filter to device 14948 add has_virtual_device_cnotexts filter to device May 20, 2024
@arthanson arthanson marked this pull request as ready for review May 20, 2024 21:14
@arthanson arthanson changed the title 14948 add has_virtual_device_cnotexts filter to device 14948 add has_virtual_device_contexts filter to device May 20, 2024
jeremystretch
jeremystretch requested changes May 21, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a test for the new filter.

netbox/dcim/filtersets.py Outdated Show resolved Hide resolved
netbox/dcim/forms/filtersets.py Outdated Show resolved Hide resolved
jeremystretch
jeremystretch approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit 753c402 into develop May 22, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 14948-virtual-device-context-filter branch May 22, 2024 15:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "has_virtual_device_context" filter to device filters in UI and API
2 participants
@arthanson @jeremystretch