Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Redis Unix sockets #16227

Merged
merged 2 commits into from
May 21, 2024

Conversation

minijackson
Copy link
Contributor

Fixes: #15962

Add a URL field for the REDIS["tasks"] and REDIS["caching"] configuration settings, which takes priority over REDIS["tasks"]["HOST"], REDIS["tasks"]["PORT"], and so on.

I added the doc recommending the URL usage for Unix sockets, but it's also possible to recommend URL for all usages, since you can also specify redis:// / rediss:// URLs.

I haven't tested this using ./manage.py test yet, I plan to do that soon. This setup has been in use in the NixOS distribution since while back, without any issue.

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minijackson!

@jeremystretch jeremystretch merged commit 60f5dd7 into netbox-community:develop May 21, 2024
3 checks passed
@tacerus
Copy link

tacerus commented May 24, 2024

Thank you!

@minijackson minijackson deleted the unix-sockets branch May 27, 2024 08:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Redis Unix sockets
3 participants