Closes #5503: ISO 8601 date in UI and alternative format as tooltip

[ypid]

Fixes: #5503

With this PR all dates in the UI are now consistently displayed.

I changed the long date format as suggested by @xkilian and confirmed by my own research.

• DATETIME_FORMAT
  • Before: July 20, 2020 4:52 p.m.
  • Now: 20th July, 2020 16:52

"20th July, 2020" would be spoken as "the 20th of July, 2020" but the "the" and "of" are never written.

I also switch from the illogical a.m./p.m. time format to military time format that can be pronounced as "sixteen hundred and fifty-two".

[DanSheps]

There seems to be a lot of repetition here, do you think it might be possible to create an include and pass the date, it would also make future modifications easier.

[ypid]

Thanks for the pointer (am was/am new to Django), done.

The only place (that I know of, and I also greped the source and so on) with dates without tooltip is object_list.html. I tried it but there it does not work so easily because the dates are passed to Jinja as SafeString. Also, I am not sure if it would be good UI design to have tooltips in the list.

[ypid]

I rebased and updated this patch to the latest develop branch. Some new date fields were introduced with NetBox 2.11. I hope I found all of them by greping the source. If not, it is not the end of the world. I will come across them eventually and fix them (potentially in a new PR). I applied this patch (including the dependency patch 2618dde) on my instance now for testing during regular use. I tested all modified pages manually already. Feel free to have a look.

[ypid]

I have been using this ever since and did not run into dates that I missed nor other issues. I would say this is ready. @jeremystretch Can you have a look?

[jeremystretch]

@ypid Adding inclusion tags to display a value (i.e. {% include 'inc/date_now_span.html' %}) should be considered poor practice. Instead, we should use a template filter for this (e.g. {{ mydate|with_current_time }}). We should also only need the one filter; the parse_date() and datatype_str() are unnecessary since we can process the value directly.

[ypid]

I improved it, thanks. I agree with you that your approach is better. Now with the date_span filter, it is very easy to just append that if new date fields are added.

[ypid]

Done.