Fixes #9754 - Fix chrome deadlock when opening some select fields #9755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkthxbye-code
changed the title
|
After having a look around I think the issue might be an infinite loop stemming from this eventlistener: As such I am not confident in this fix, or any fix that calls focus() on the input. Not sure how to fix it with messing with unregistering the listener, and as we are already kinda misusing slim-select internals, that's not something I'm comfortable handling correct. I created a new PR to revert the previous changes. When that is done, we need to re-open #9632 and wat for someone with more js experience to show up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9754
This PR tries to fix an unidentified deadlock in chrome when opening certain slim-select fields. I tested as much as I could, but as I am still not sure what actually causes this, I think another valid (maybe safer) solution would be to revert #9735 and #9696 and reopen #9632 until someone who can untangle the hell of async events being fired when opening a slim-select field - I'll let you decide @jeremystretch .