set mux to false by default #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SekiBetu
commented
Dec 29, 2020
HMBSbige
approved these changes
Dec 30, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in
#230
v2ray/v2ray-core#2412
v2ray/v2ray-core#2194
v2ray/v2ray-core#1969
v2ray/v2ray-core#1963
this has already been discussed that mux has some potential problems,
although, there is a fix on this v2fly/v2ray-core#168 , but it doesn't solve the problem completely.
so, i think it would be better if mux were set to false by default and use it at users' own risk.