feat: allow to disable parent instance #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyam8
requested review from
BillKalaitzis,
witalisoft and
M4itee
and removed request for
a team
Closed
M4itee
approved these changes
Sep 19, 2022
witalisoft
reviewed
Sep 19, 2022
| @@ -141,7 +142,7 @@ The following table lists the configurable parameters of the netdata chart and t | |||
| | `parent.claiming.room` | Comma separated list of claim rooms IDs | `""` | | |||
| | `parent.extraVolumeMounts` | Additional volumeMounts to add to the parent pods | `[]` | | |||
| | `parent.extraVolumes` | Additional volumes to add to the parent pods | `[]` | | |||
| | `k8sState.enabled` | Install this Deployment to gather data fr K8s cluster | `yes` | | |||
| | `k8sState.enabled` | Install this Deployment to gather data fr K8s cluster | `yes` | | |||
witalisoft
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #306
Tested locally using Kind cluster w/ and w/o enabled parent instance.