Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression]: go.d: package slices is not in GOROOT #16278

Closed
k0ste opened this issue Oct 26, 2023 · 2 comments · Fixed by netdata/go.d.plugin#1394
Closed

[Regression]: go.d: package slices is not in GOROOT #16278

k0ste opened this issue Oct 26, 2023 · 2 comments · Fixed by netdata/go.d.plugin#1394
Labels
bug needs triage Issues which need to be manually labelled

Comments

@k0ste
Copy link
Contributor

k0ste commented Oct 26, 2023

Bug description

Hi, I can't build RPM with go.d.plugin 0.56.2 and higher

The actual error is:

agent/filestatus/store.go:9:2: package slices is not in GOROOT (/usr/lib/golang/src/slices)

Until version 0.56.1 build was ok

make[2]: Leaving directory '/builddir/build/BUILD/netdata-v1.43.1'
make[1]: Leaving directory '/builddir/build/BUILD/netdata-v1.43.1'
+ cd /builddir/build/BUILD/go.d.plugin/go.d.plugin-0.56.2
+ sed -i 's|CGO_ENABLED=0 ||' hack/go-build.sh
+ TRAVIS_TAG=0.56.2
+ /usr/bin/make build
rm -rf bin
hack/go-build.sh
Building binaries for version: 0.56.2
Building linux/arm64
agent/filestatus/store.go:9:2: package slices is not in GOROOT (/usr/lib/golang/src/slices)
make: *** [Makefile:17: build] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.v6ErEq (%build)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.v6ErEq (%build)
Child return code was: 1
EXCEPTION: [Error("Command failed: \n # bash --login -c '/usr/bin/rpmbuild -bb  --target aarch64 --nodeps /builddir/build/SPECS/netdata.spec'\n", 1)]
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
             ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/mockbuild/util.py", line 597, in do_with_status
    raise exception.Error("Command failed: \n # %s\n%s" % (cmd_pretty(command, env), output), child.returncode)
mockbuild.exception.Error: Command failed:
 # bash --login -c '/usr/bin/rpmbuild -bb  --target aarch64 --nodeps /builddir/build/SPECS/netdata.spec

Expected behavior

Complete build netdata packages

Steps to reproduce

  1. Build RPM package with mock

Installation method

from source

System info

CPU info:
Architecture:                       aarch64
CPU op-mode(s):                     64-bit
Byte Order:                         Little Endian
CPU(s):                             8
On-line CPU(s) list:                0-7
Vendor ID:                          0x00
Model name:                         -
Model:                              0
Thread(s) per core:                 1
Core(s) per cluster:                8
Socket(s):                          -
Cluster(s):                         1
Stepping:                           0x0
BogoMIPS:                           48.00
Flags:                              fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 asimddp sha512 asimdfhm dit uscat ilrcpc flagm ssbs sb paca pacg dcpodp flagm2 frint
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; __user pointer sanitization
Vulnerability Spectre v2:           Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected


Memory:
               total        used        free      shared  buff/cache   available
Mem:         4027736      500296     1511704      176240     2015736     3057540
Swap:        1048572       92564      956008


Storage (chroot, cache_topdir):
Filesystem        Size  Used Avail Use% Mounted on
overlay            63G  5.5G   54G  10% /
/host_mark/Users  246G  176G   71G  72% /rpmbuild

Netdata build info

---

Additional info

No response

@k0ste k0ste added bug needs triage Issues which need to be manually labelled labels Oct 26, 2023
@ilyam8
Copy link
Member

ilyam8 commented Oct 26, 2023

@k0ste that is because golang 1.21+ is required.

k0ste added a commit to k0ste/go.d.plugin that referenced this issue Oct 26, 2023
@k0ste
Copy link
Contributor Author

k0ste commented Oct 26, 2023

@k0ste that is because golang 1.21+ is required.

Thanks! netdata/go.d.plugin#1394

k0ste added a commit to k0ste/go.d.plugin that referenced this issue Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Issues which need to be manually labelled
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants