Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Set required golang to 1.21 #1394

Merged
merged 2 commits into from Oct 26, 2023
Merged

Set required golang to 1.21 #1394

merged 2 commits into from Oct 26, 2023

Conversation

k0ste
Copy link
Contributor

@k0ste k0ste commented Oct 26, 2023

@ilyam8
Copy link
Member

ilyam8 commented Oct 26, 2023

Thanks, @k0ste!

@k0ste
Copy link
Contributor Author

k0ste commented Oct 26, 2023

Added another commit, Run go get -u=patch ./... command for major version changes. Seems this also needed for golang

@ilyam8
Copy link
Member

ilyam8 commented Oct 26, 2023

@k0ste please undo the last commit, it will break the plugin in a lot of places (e.g. won't compile on FreeBSD because wgctrl - cross-compilation no longer works with latest). I have dependabot setup and I update direct dependencies, if there is something is not up to date - it breaks the plugin or requires additional actions (e.g. regenerate generated code after updating radius).

@k0ste
Copy link
Contributor Author

k0ste commented Oct 26, 2023

Understood, done. Do I need to do something for fix the CI pipeline issue?

@ilyam8
Copy link
Member

ilyam8 commented Oct 26, 2023

@k0ste rebase onto the master, mysql testes were broken in master, just pushed a commit to fix them.

@k0ste
Copy link
Contributor Author

k0ste commented Oct 26, 2023

Rebased

@ilyam8 ilyam8 merged commit 9356e17 into netdata:master Oct 26, 2023
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants