Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstaller script should be self-contained #5031

Closed
paulfantom opened this issue Dec 18, 2018 · 0 comments
Closed

Uninstaller script should be self-contained #5031

paulfantom opened this issue Dec 18, 2018 · 0 comments
Assignees
@paulfantom
Labels
area/packaging Packaging and operating systems support bug priority/low A 'nice to have' not critical issue
Milestone
v1.12-rc3

Comments

@paulfantom
Copy link
Contributor

Bug report summary

While working on #5009 I found a super easy way to make uninstaller script not work. Since uninstaller script sources 2 other files and one of them contains more of its logic (functions.sh) then just moving one of those files to different location breaks uninstaller script.

OS / Environment

All

Component Name

packaging
uninstaller

Steps To Reproduce
  1. Install
  2. Move functions.sh to other location
  3. Run uninstaller
Expected behavior

Uninstaller contains all logic needed to perform uninstallation.
@paulfantom paulfantom added bug area/packaging Packaging and operating systems support priority/low A 'nice to have' not critical issue labels Dec 18, 2018
@paulfantom paulfantom mentioned this issue Dec 18, 2018
Merged
paulfantom added a commit that referenced this issue Dec 19, 2018
@paulfantom
Move installer dir under packaging (#5009)
545aa97 
* move installer dir under packaging

* fix docs creation

* uninstaller is broken and fix will be created in #5031

* fix links in docs
@paulfantom paulfantom self-assigned this Jan 3, 2019
@paulfantom paulfantom added this to the v1.12 milestone Jan 3, 2019
This was referenced Jan 3, 2019
Closed
Closed
@paulfantom paulfantom mentioned this issue Jan 14, 2019
Merged
kiku-jw pushed a commit to kiku-jw/netdata that referenced this issue Mar 4, 2019
@paulfantom @kiku-jw
Move installer dir under packaging (netdata#5009)
f328724 
* move installer dir under packaging

* fix docs creation

* uninstaller is broken and fix will be created in netdata#5031

* fix links in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulfantom paulfantom

Labels
area/packaging Packaging and operating systems support bug priority/low A 'nice to have' not critical issue
Projects
None yet
Milestone
v1.12-rc3
Development

No branches or pull requests
1 participant
@paulfantom