-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page duty V2 #10189
Page duty V2 #10189
Conversation
@thiagoftsm, I am not aware of any dashboard configuration needed. It looks to me as if the alerts don't get triggered/accepted by PagerDuty. You can try using the "Netdata Cloud Production (alertmanager)" for a test if you like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM.
According the Pagerduty page, it is necessary to request access to have this new version enabled, I won't merge this PR until we have conditions to test. It looks like that we are not having any problem, considering the |
f165387
@vlvkobal , @ilyam8 and @knatsakis I pushed another commit bringing back the version 1 as default, and I also added another variable for users to select the newest version after they require usage for PagerDuty. We will need to move forward with this variable, until Pager Duty set version 2 as default. |
Summary
Fixes #10151
The main goal of this PR is to use the API V2 that Pager duty, but as we agreed with @Ferroin we are also using this PR to change the indentation used inside the file.
Component Name
Alarm notify
Test Plan
1 - Ask @knatsakis to invite you for Pagerduty.
2 - Create a new service.
3 - Get a key for API V2.
4 - Set the variable
DEFAULT_RECIPIENT_PD
5 - Go to
plugins.d
directorycd /usr/libexec/netdata/plugins.d/
6 - Run the test:
./alarm-notify.sh test
Additional Information
When I ran the tests, I also kept
telegram
,slack
andhangout
enabled, and I received the alarms on all channels.@knatsakis it was the first time that I worked with
PagerDuty
. I could not see the alarms on the service that I created, but I am always receiving202
as you can seeI think I am missing something on dashboard configuration.