-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node message support for ACLK new architecture #11514
Conversation
an additional small nit picky comment would be should those files and functions be called sqlite? I know they are called out of your event loop but same time this particular part seems it has nothing to do with database |
Sorry, noticed some build failures on ubuntu 16.04, will have a quick look... |
I see that -- I will take a look as well |
I think if fails because ACLK_NG cannot be built there (lack of protobuf is mentioned in configure), so the compile goes on to build with Legacy. Maybe the #ifdef should be for ACLK_NG ? Cause |
But I also get some (which when handled, proceeds to build ACLK_NG, and the binary links):
|
Checking ACLK_NG works Also works as - is when you pass |
I think the latest protobuf from their repositories in 16.04 seems to be |
Added ACLK_NG check for now |
Rebased |
Summary
Add initial support for node info message
Component Name
aclk, database
Test Plan
The code is not active yet (it is tested with the new architecture in a separate branch)