Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable eBPF compilation in different platforms #11566

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

thiagoftsm
Copy link
Contributor

Summary

This PR is bringing the same fix added by @Ferroin here for Netdata source-code.

We have plans to bring eBPF plugin for different platforms, but while it is not merged and considering the reported problems per Slack when we use the latest libbpf, the safest is to disable.

Component Name

netdata-installer

Test Plan

1 - Compile this PR on X86_64, and verify that eBPF.plugin is compiled and it runs normally
2 - Compile this PR on different platform, and verify that eBPF.plugin is not compiled.

Additional Information

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Sep 23, 2021
@thiagoftsm thiagoftsm merged commit 9cede66 into netdata:master Sep 23, 2021
@thiagoftsm thiagoftsm deleted the disable_compilation_on_arm branch September 23, 2021 19:11
@Ferroin
Copy link
Member

Ferroin commented Sep 24, 2021

This ideally should not have been merged without a review from a code owner. The general premise is correct, but we most certainly do not want to hard fail on non-x86 platforms when users haven’t explicitly disabled eBPF.

I’ll have a follow up PR later today to fix this, but in the short term expect some users to report updater issues.

@ilyam8
Copy link
Member

ilyam8 commented Sep 24, 2021

This ideally should not have been merged without a review from a code owner.

👍

but we most certainly do not want to hard fail

@thiagoftsm just updated should_install_ebpf function, so we just don't install the ebpf.plugin plugin and log "Currently eBPF is only supported on Linux on X86_64.". What do you mean by hard fail? 🤔

@Ferroin
Copy link
Member

Ferroin commented Sep 24, 2021

This ideally should not have been merged without a review from a code owner.

but we most certainly do not want to hard fail

@thiagoftsm just updated should_install_ebpf function, so we just don't install the ebpf.plugin plugin and log "Currently eBPF is only supported on Linux on X86_64.". What do you mean by hard fail?

Ah, no, you’re correct. I mistook run_failed for fatal. This should be fine as is.

@ilyam8
Copy link
Member

ilyam8 commented Sep 24, 2021

I mistook run_failed for fatal

Actually did the same and had to look for run_failed function before approving the PR 😄

@thiagoftsm
Copy link
Contributor Author

This ideally should not have been merged without a review from a code owner.

+1

but we most certainly do not want to hard fail

@thiagoftsm just updated should_install_ebpf function, so we just don't install the ebpf.plugin plugin and log "Currently eBPF is only supported on Linux on X86_64.". What do you mean by hard fail? thinking

The hard fail was not written by me, this is ancient text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants