-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps: disable reporting min/avg/max group uptime by default #11609
Conversation
@ilyam8 code is working as expected, but before I approve this PR, I will suggest we change apps.plugin documentation saying what happens when we enable this option. |
@thiagoftsm I've checked the apps.plugin documentation (did it before marking the PR ready for review) and I see we don't really describe all the available options. We just briefly mention that there are some, use See the end of the Configuration section. Moreover, as I mentioned in the OP, I consider min/avg/max uptime functionality very questionable and not really useful. |
Yes you are right, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything worked as expected. LGTM!
Summary
The min/avg/max group uptime charts are not really useful (unlike "carried over time uptime"), I think we need to disable them by default.
This PR disables reporting those charts by default. They can be enabled using
with-detailed-uptime
command-line option.Component Name
collectors/apps.plugin
Test Plan
Run the plugin w/ and w/o
with-detailed-uptime
.Additional Information