Include libatomic again to allow protobuf to resolve #11917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrZammler
requested review from
ReifiedException and
maneamarius
as code owners
vkalintiris
approved these changes
Dec 20, 2021
vkalintiris
reviewed
Dec 20, 2021
ReifiedException
approved these changes
Dec 21, 2021
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
-latomicreference to the linker after the protobuf libraries, so thatlibprotobuf.acan resolve__atomicfunctions if needed.Linking is ok without this PR if ml is enabled. If it is not (
--disable-ml), at the linking stage the errorarena.cc:(.text+0xab4): undefined reference to '__atomic_fetch_add_8'is produced by the linker forlibprotobuf.aComponent Name
Build
Test Plan
This was tested on a clean Raspbian 11 (bullseye), as a response to #11915.
On a clean Raspbian installation, on a raspberry, try to compile master, or a latest stable release.
Specify
--disable-ml. Link might fail. Using the changes in this PR, linking should succeed.