Updated formatting issues and copy #11944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the link to the screenshot and improved the copy. However, I need a bit more input for the last sentence in the note (line 78). I left the Google Analytics link, because I figured that we will sweep them out in a different initiative.
MrZammler
reviewed
Jan 26, 2022
MrZammler
reviewed
Jan 26, 2022
MrZammler
reviewed
Jan 26, 2022
ilyam8
reviewed
Jan 27, 2022
kickoke
commented
Jan 31, 2022
kickoke
commented
Jan 31, 2022
kickoke
commented
Jan 31, 2022
kickoke
commented
Jan 31, 2022
MrZammler
reviewed
Feb 1, 2022
kickoke
commented
Feb 2, 2022
Co-authored-by: Tina Luedtke <kickoke@users.noreply.github.com>
kickoke
commented
Feb 2, 2022
MrZammler
approved these changes
Feb 2, 2022
ilyam8
approved these changes
Feb 2, 2022
maneamarius
pushed a commit
to maneamarius/netdata
that referenced
this pull request
Feb 3, 2022
Co-authored-by: Tina Luedtke <kickoke@users.noreply.github.com> Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
maneamarius
pushed a commit
to maneamarius/netdata
that referenced
this pull request
Feb 4, 2022
Co-authored-by: Tina Luedtke <kickoke@users.noreply.github.com> Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the link to the screenshot and improved the copy.
However, I need a bit more input for the last sentence in the note (line 78).
I left the Google Analytics link, because I figured that we will sweep them out in a different initiative.
If you feel like another person would be a better reviewer, please add them to the PR.