Add support to the updater to toggle auto-updates on and off. #12202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds the updater script to our native packages.
github-actions
bot
added
area/docs
area/packaging
Ferroin
requested review from
iigorkarpov,
maneamarius,
vkalintiris,
DShreve2 and
kickoke
as code owners
kickoke
reviewed
Feb 28, 2022
It is up to date, the documentation changes got caught in #12182 as collateral damage, and this PR is re-adding them. |
ilyam8
reviewed
Feb 28, 2022
ilyam8
reviewed
Feb 28, 2022
ilyam8
reviewed
Feb 28, 2022
ilyam8
reviewed
Mar 1, 2022
ilyam8
reviewed
Mar 1, 2022
ilyam8
reviewed
Mar 1, 2022
ilyam8
approved these changes
Mar 2, 2022
maneamarius
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This restores a subset of the changes that were reverted in #12182 that are generally known to be clean and working correctly.
Specifically, it re-adds the code in the updater script for toggling automatic updates on and off, the changes in the packaging code that include the updater script in our native packages, and the associated documentation changes for both parts.
The kickstart script integration will be handled in a separate PR at some point later this week.
Test Plan
Testing of the new
--enable-auto-updatesand--disable-auto-updatesoptions can be done trivially on any existing static or locally built install by downloading the copy of the script from this PR and simply running it with the appropriate option.