Switch to using netdata-updater.sh to toggle auto updates on and off when installing. #12296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/docs
area/packaging
Ferroin
requested review from
iigorkarpov,
maneamarius,
DShreve2 and
kickoke
as code owners
kickoke
reviewed
Mar 4, 2022
Ferroin
force-pushed
the
finish-updater-handling-migration
branch
from
395fb75
to
b2de617
Compare
|
Rebased to pick up changes in master, and fixed ambiguous heading in docs. |
maneamarius
suggested changes
Mar 11, 2022
Agreed, but that’s orthogonal to this PR (changes in this PR are not what has caused this warning, so the warning should not be considered as blocking this PR). |
Co-authored-by: Tina Luedtke <kickoke@users.noreply.github.com>
Ferroin
force-pushed
the
finish-updater-handling-migration
branch
from
b2de617
to
6b6930a
Compare
iigorkarpov
approved these changes
Mar 21, 2022
maneamarius
approved these changes
Mar 21, 2022
This was referenced Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will allow us to handle control of auto-updates in a consistent manner no matter which install method was used.
Test Plan
Full testing will require waiting until on or after 2022-03-03, as prior to that nightly package builds will not include the updater script.
General testing is a simple case of verifying that auto-updates are enabled (or disabled) correctly when using the copy of the kickstart script from this PR.
Additional Information
This is the second half of #12202.