UpdateNodeCollectors message #13330
Merged
UpdateNodeCollectors message #13330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrZammler
requested review from
thiagoftsm,
vkalintiris,
stelfrag and
underhood
as code owners
underhood
approved these changes
Jul 7, 2022
thiagoftsm
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
This PR is working as expected
bash-5.1# grep "NODE COLLECTORS SENT" /var/log/netdata/access.log
2022-07-07 18:08:12: ACLK RES [e7974429-c75e-4d58-9ee3-5d2620a017f8 (hades)]: NODE COLLECTORS SENT
2022-07-07 18:12:31: ACLK RES [e7974429-c75e-4d58-9ee3-5d2620a017f8 (hades)]: NODE COLLECTORS SENTLGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
UpdateNodeCollectorsprotobuf message. It will contain a list of collector's modules and plugins. From that list the FE will render a series of services, supported by the agent.The message will follow 30 seconds after the
UpdateNodeInfomessage. This is to allow enough time for collectors to be activated and included in the message.BE has been prepared to receive it.
Test Plan
There should be a line stating
NODE COLLECTORS SENTinaccess.log. It has been tested with @vkuznecovas in testing.Additional Information
For users: How does this change affect me?