feat(cgroups.plugin): resolve nomad containers name (docker driver only) #13481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
@xkisu, hey 👋 Is this name ok? What do you think? |
ilyam8
changed the title
cakrit
reviewed
Aug 3, 2022
cakrit
reviewed
Aug 3, 2022
vlvkobal
approved these changes
Aug 3, 2022
thiagoftsm
approved these changes
Aug 3, 2022
Sorry, I missed this! Yeah that's perfect, I've been using that format on my fork for a couple of weeks and it's got just enough information to be useful to Nomad admins and not be too long 👍 |
|
Big thanks for helping us, @xkisu! As it turned out it was easy to implement, but somehow I missed that Nomad exports env vars when was doing the initial investigation. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Aug 12, 2022
https://build.opensuse.org/request/show/994622 by user mia + dimstar_suse - Drop netdata-smartd-log-path.patch - Update to 1.36.0 (go.d.plugin 0.35.0) Collectors * New + Add PgBouncer collector (go.d/pgbouncer) gh#netdata/netdata#748 + Add WireGuard collector (go.d/wireguard) gh#netdata/netdata#744 + Add PostgresSQL collector (go.d/postgres) gh#netdata/netdata#718 + Add Chrony collector (go.d/chrony) gh#netdata/netdata#678 + Add Kubernetes State collector (go.d/k8s_state) gh#netdata/netdata#673 * Improvements + Add WireGuard description and icon to dashboard info gh#netdata/netdata#13483 + Resolve nomad containers name (cgroups.plugin) gh#netdata/netdata#13481 + Update postgres dashboard info gh#netdata/netdata#13474 + Improve Chrony dashboard info gh#netdata/netdata#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #12419
Closes: #13475
This PR adds containers name resolution for Nomad tasks. Name: "NAMESPACE-JOBNAME-TASKNAME-SHORTALLOCID".
Before this PR:
docker ps ...ifdockercommand is available (Netdata running on the host).dockercommand is not available (Netdata running inside a Docker container).This PR changes:
docker inspect ...ifdockercommand is available. This is equivalent to the ContainerInspect endpoint (but we can apply additional formatting).Test Plan
Tested both scenarios: Netdata is running in a Docker container/Netdata installed on the host.
1st one is nomad, 2nd one is docker.
Additional Information
For users: How does this change affect me?