-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eBPF different improvements #13624
Merged
Merged
eBPF different improvements #13624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoftsm
requested review from
Ferroin,
vkalintiris and
vlvkobal
as code owners
September 4, 2022 22:05
thiagoftsm
changed the title
eBPF improve PID monitoring and reduce CPU/Memory usage
eBPF different improvements
Sep 4, 2022
github-actions
bot
added
area/collectors
Everything related to data collection
area/packaging
Packaging and operating systems support
collectors/ebpf
labels
Sep 4, 2022
thiagoftsm
force-pushed
the
ebpf_last_step
branch
from
September 5, 2022 22:06
573ea75
to
fc3d7fe
Compare
thiagoftsm
requested review from
MrZammler and
underhood
and removed request for
vkalintiris
September 7, 2022 13:12
Fixes or probably fixes? |
Fixes, the tests are showing that ebpf.plugin is always using less resources than apps. |
vlvkobal
approved these changes
Sep 7, 2022
underhood
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/collectors
Everything related to data collection
area/packaging
Packaging and operating systems support
collectors/ebpf
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13626
This PR is fixing the following issues:
OOMkill
to run there.netdata.ebpf_threads
chart when legacy code is used.and it also brings less CPU/Memory usage and
libbpf 1.0
.Test Plan
libbpf
warnings:grep libbpf /var/log/netdata/error.log
apps.cpu
and verify that ebpf.plugin is lower or equalapps.plugin
.bpftool
installed, you can runbpftool map show | grep 10922
and verify that PID tables are not having more the default size32768
, if you do not have take a look in the table present atAdditional information
.CentOS 7.9
VM, compile this branch and take a look that you won't have theOOMkill
thread started, instead you will have the following warning:Additional Information
This PR was tested on:
For users: How does this change affect me?
Describe the PR affects users: - Which area of Netdata is affected by the change? ebpf.plugin - Can they see the change or is it an under the hood? If they can see it, where? Yes, they can use `apps.cpu` to verify that plugin is using less resource. - How is the user impacted by the change? A plugin more stable and faster. - What are there any benefits of the change? A better plugin