Add proper SUID fallback for DEB plugin packages. #15803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
ilyam8
reviewed
Aug 14, 2023
ilyam8
approved these changes
Aug 14, 2023
thiagoftsm
approved these changes
Aug 14, 2023
Ferroin
added a commit
that referenced
this pull request
Aug 16, 2023
* Add proper SUID fallback for DEB plugin packages. * Update contrib/debian/netdata-plugin-perf.postinst --------- Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On systems where file capabilities are not usable, we need to properly mark plugins that use them as SUID 0 so that they still are able to work.
This code is not expected to run on a vast majority of systems (possibly not even any systems) as it is vanishingly rare that file capabilities are not usable.
Test Plan
CI passes on this PR.
Proper validation of these changes is extremely difficult, because it’s actually pretty hard to make file capabilities not work, but it’s probably fine to only verify that this breaks nothing since that case is so unlikely to occur in the wild.