Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper SUID fallback for DEB plugin packages. #15803

Merged
merged 2 commits into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion contrib/debian/netdata-plugin-apps.postinst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ set -e
case "$1" in
configure|reconfigure)
chown root:netdata /usr/libexec/netdata/plugins.d/apps.plugin
setcap "cap_dac_read_search=eip cap_sys_ptrace=eip" /usr/libexec/netdata/plugins.d/apps.plugin
chmod 0750 /usr/libexec/netdata/plugins.d/apps.plugin
if ! setcap "cap_dac_read_search=eip cap_sys_ptrace=eip" /usr/libexec/netdata/plugins.d/apps.plugin; then
chmod -f 4750 /usr/libexec/netdata/plugins.d/apps.plugin
fi
;;
esac

Expand Down
5 changes: 4 additions & 1 deletion contrib/debian/netdata-plugin-debugfs.postinst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ set -e
case "$1" in
configure|reconfigure)
chown root:netdata /usr/libexec/netdata/plugins.d/debugfs.plugin
setcap "cap_dac_read_search=eip" /usr/libexec/netdata/plugins.d/debugfs.plugin
chmod 0750 /usr/libexec/netdata/plugins.d/debugfs.plugin
if ! setcap "cap_dac_read_search=eip" /usr/libexec/netdata/plugins.d/debugfs.plugin; then
chmod -f 4750 /usr/libexec/netdata/plugins.d/debugfs.plugin
fi
;;
esac

Expand Down
5 changes: 4 additions & 1 deletion contrib/debian/netdata-plugin-go.postinst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ set -e
case "$1" in
configure|reconfigure)
chown root:netdata /usr/libexec/netdata/plugins.d/go.d.plugin
setcap "cap_net_admin=eip cap_net_raw=eip" /usr/libexec/netdata/plugins.d/go.d.plugin
chmod 0750 /usr/libexec/netdata/plugins.d/go.d.plugin
if ! setcap "cap_net_admin=eip cap_net_raw=eip" /usr/libexec/netdata/plugins.d/go.d.plugin; then
chmod -f 4750 /usr/libexec/netdata/plugins.d/go.d.plugin
fi
;;
esac

Expand Down
8 changes: 8 additions & 0 deletions contrib/debian/netdata-plugin-perf.postinst
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,18 @@ set -e
case "$1" in
configure|reconfigure)
chown root:netdata /usr/libexec/netdata/plugins.d/perf.plugin
chmod 0750 /usr/libexec/netdata/plugins.d/perf.plugin

if capsh --supports=cap_perfmon 2>/dev/null; then
setcap cap_perfmon+ep /usr/libexec/netdata/plugins.d/perf.plugin
ret="$?"
else
setcap cap_sys_admin+ep /usr/libexec/netdata/plugins.d/perf.plugin
ret="$?"
fi

if [ "${ret}" -ne 0 ]; then
chmod -f 4750 /usr/libexec/netdata/plugins.d/perf.plugin
fi
;;
esac
Expand Down
5 changes: 4 additions & 1 deletion contrib/debian/netdata-plugin-slabinfo.postinst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ set -e
case "$1" in
configure|reconfigure)
chown root:netdata /usr/libexec/netdata/plugins.d/slabinfo.plugin
setcap "cap_dac_read_search=eip" /usr/libexec/netdata/plugins.d/slabinfo.plugin
chmod 0750 /usr/libexec/netdata/plugins.d/slabinfo.plugin
if ! setcap "cap_dac_read_search=eip" /usr/libexec/netdata/plugins.d/slabinfo.plugin; then
chmod -f 4750 /usr/libexec/netdata/plugins.d/slabinfo.plugin
fi
;;
esac

Expand Down
5 changes: 4 additions & 1 deletion contrib/debian/netdata-plugin-systemd-journal.postinst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ set -e
case "$1" in
configure|reconfigure)
chown root:netdata /usr/libexec/netdata/plugins.d/systemd-journal.plugin
setcap "cap_dac_read_search=eip" /usr/libexec/netdata/plugins.d/systemd-journal.plugin
chmod 0750 /usr/libexec/netdata/plugins.d/systemd-journal.plugin
if ! setcap "cap_dac_read_search=eip" /usr/libexec/netdata/plugins.d/systemd-journal.plugin; then
chmod -f 4750 /usr/libexec/netdata/plugins.d/systemd-journal.plugin
fi
;;
esac

Expand Down