Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.d: use real time for calc sinceLast #4720

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Nov 22, 2018

Summary

Fixes: #3752

Component Name

python.d.plugin

Additional Information

Internally python.d.plugin uses monotonic clock for all calculations.

After this PR:

  • monotonic for calculation sleep time (next run)
  • realtime for clock delta

@ilyam8 ilyam8 requested a review from Ferroin November 22, 2018 23:08
@ilyam8 ilyam8 self-assigned this Nov 22, 2018
@ilyam8 ilyam8 added this to the v1.12-rc0 milestone Nov 22, 2018
@ilyam8 ilyam8 changed the title [wip] python.d: use real time for calc sinceLast python.d: use real time for calc sinceLast Nov 23, 2018
@ilyam8 ilyam8 merged commit 44eef8d into netdata:master Nov 26, 2018
@ilyam8 ilyam8 deleted the calcSinceLast_fix branch November 28, 2018 17:30
@paulfantom paulfantom added the area/collectors Everything related to data collection label Nov 29, 2018
kiku-jw pushed a commit to kiku-jw/netdata that referenced this pull request Mar 4, 2019
* use real time clock to calc since last update

* python.d: remove unused attr from RuntimeCounters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python plugins got behind by 5 seconds
2 participants