RabbitMQ chart for message rates should be "line" #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ilyam8
approved these changes
Dec 4, 2018
|
@dex4er thank you for contributing 👍 |
kiku-jw
pushed a commit
to kiku-jw/netdata
that referenced
this pull request
Mar 4, 2019
* rabbitmq_local.message_rates chart is line * rabbitmq_local.memory and disk_space charts should be area
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I changed a types of chars for RabbitMQ.
Chart for message rates should be "line". It is because for correct system the "ack", "deliver" and "publish" should be similar and it is much easier to notice it with "line" type of chart.
Usually for memory and disk space we use "area" type so it is changed too.
Component Name
collector rabbitmq