Health giving wrong message #6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside rrdcalc_unlink_and_free I wrote a not proper way to check the presence of an element inside the AVL, so I was raising an error without to do the correct checks!
mfundul
approved these changes
Jul 2, 2019
cakrit
approved these changes
Jul 5, 2019
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
Inside rrdcalc_unlink_and_free I wrote a not proper way to check the presence of an element inside the AVL, so I was raising an error without to do the correct checks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The health was given wrong message when the Netdata was closed, because there was not a proper check of the index before to clean it. This PR fix the appear of improper "ERROR : MAIN : Cannot remove the health alarm index" that was happening when we close netdata, no less important it let more clear which index is raising errors when they really happen.
Component Name
Health
Additional Information