-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7040 enable stable channel option #7082
Conversation
Manage this branch in SquashTest this branch here: https://7040-enable-stable-channel-opt-fx7fm.squash.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @knatsakis ,
I think we are having problems in our check system, months ago I wrote a PR using some conditions like yours and I had to change due shellcheck
results, today I saw that you used the same comparison that was rejected to me and when I ran the shellcheck
in both files I got the expected error report:
Please, can you check why our shellcheck
is not reporting correctly? No less important, can you run in your side and fix the list of errors displayed in the image?
Thank you!
Hi @thiagoftsm, As per our discussion, let's proceed by ignoring the shellcheck errors and open a new ticket for the lack of shellcheck in travis. |
All right, I already created a new issue with the errors reported here and on 7083. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything worked as expected during my tests with this PR on a Debian 9.11 and latest version of docker available in this distribution.
install-or-update.sh now accepts the --stable-channel option
1c4552d
to
e1dccc1
Compare
* Partial fix for netdata#7040 install-or-update.sh now accepts the --stable-channel option * Add missing quotes to sed command
* Partial fix for netdata#7040 install-or-update.sh now accepts the --stable-channel option * Add missing quotes to sed command
Summary
Partial fix for #7040
Component Name
packaging/makeself/install-or-update.sh
Additional Information
Another PR will be needed, in order to update kickstart-static64.sh and pass the --stable-channel options when needed