Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7040 enable stable channel option #7082

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Conversation

knatsakis
Copy link
Contributor

Summary

Partial fix for #7040

  • install-or-update.sh now accepts the --stable-channel option and updates the environment file
Component Name

packaging/makeself/install-or-update.sh

Additional Information

Another PR will be needed, in order to update kickstart-static64.sh and pass the --stable-channel options when needed

@squash-labs
Copy link

squash-labs bot commented Oct 13, 2019

Manage this branch in Squash

Test this branch here: https://7040-enable-stable-channel-opt-fx7fm.squash.io

@cosmix cosmix added the area/packaging Packaging and operating systems support label Oct 14, 2019
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @knatsakis ,

I think we are having problems in our check system, months ago I wrote a PR using some conditions like yours and I had to change due shellcheck results, today I saw that you used the same comparison that was rejected to me and when I ran the shellcheck in both files I got the expected error report:

Netdata_after11

Please, can you check why our shellcheck is not reporting correctly? No less important, can you run in your side and fix the list of errors displayed in the image?

Thank you!

@knatsakis
Copy link
Contributor Author

Hi @thiagoftsm,

As per our discussion, let's proceed by ignoring the shellcheck errors and open a new ticket for the lack of shellcheck in travis.

@thiagoftsm
Copy link
Contributor

Hi @thiagoftsm,

As per our discussion, let's proceed by ignoring the shellcheck errors and open a new ticket for the lack of shellcheck in travis.

All right, I already created a new issue with the errors reported here and on 7083.

@thiagoftsm thiagoftsm self-requested a review October 15, 2019 18:24
thiagoftsm
thiagoftsm previously approved these changes Oct 15, 2019
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as expected during my tests with this PR on a Debian 9.11 and latest version of docker available in this distribution.

cosmix
cosmix previously approved these changes Oct 17, 2019
install-or-update.sh now accepts the --stable-channel option
@knatsakis knatsakis dismissed stale reviews from cosmix and thiagoftsm via e1dccc1 October 18, 2019 13:15
@knatsakis knatsakis force-pushed the 7040-enable-stable-channel-option branch from 1c4552d to e1dccc1 Compare October 18, 2019 13:15
@knatsakis knatsakis merged commit cd097aa into master Oct 18, 2019
@knatsakis knatsakis deleted the 7040-enable-stable-channel-option branch October 18, 2019 14:00
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
* Partial fix for netdata#7040

install-or-update.sh now accepts the --stable-channel option

* Add missing quotes to sed command
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
* Partial fix for netdata#7040

install-or-update.sh now accepts the --stable-channel option

* Add missing quotes to sed command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants