Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database: include limits.h before using LONG_MAX #7224

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

mniestroj
Copy link
Contributor

Summary

Include limits.h before using LONG_MAX. This fixes build with musl standard C library.

Component Name

database

Additional Information

@squash-labs
Copy link

squash-labs bot commented Oct 29, 2019

Manage this branch in Squash

Test this branch here: https://mniestrojfix-build-with-musl-2olte.squash.io

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mfundul mfundul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this in libnetdata/libnetdata.h together with the other system include statements?

This fixes build with musl standard C library.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
@mniestroj
Copy link
Contributor Author

@mfundul Moved include statement inside libnetdata/libnetdata.h as requested.

Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compiled netdata with this changes and everything was fine, my netdata also worked as expceted.

@ilyam8
Copy link
Member

ilyam8 commented Oct 29, 2019

@mniestroj please sign the CLA

@mfundul mfundul merged commit fdeac75 into netdata:master Oct 29, 2019
@mfundul
Copy link
Contributor

mfundul commented Oct 29, 2019

Thank you @mniestroj

jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
This fixes build with musl standard C library.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
@mniestroj mniestroj deleted the fix-build-with-musl branch January 4, 2020 20:13
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
This fixes build with musl standard C library.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants