-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
database: include limits.h before using LONG_MAX #7224
Conversation
Manage this branch in SquashTest this branch here: https://mniestrojfix-build-with-musl-2olte.squash.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put this in libnetdata/libnetdata.h
together with the other system include statements?
This fixes build with musl standard C library. Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
5a3f93e
to
bce81d6
Compare
@mfundul Moved include statement inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compiled netdata with this changes and everything was fine, my netdata also worked as expceted.
@mniestroj please sign the CLA |
Thank you @mniestroj |
This fixes build with musl standard C library. Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
This fixes build with musl standard C library. Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
Summary
Include limits.h before using LONG_MAX. This fixes build with musl standard C library.
Component Name
database
Additional Information