Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectors/python.d/phpfpm: fix readme and per process chart titles #7876

Merged
merged 6 commits into from
Jan 28, 2020
Merged

collectors/python.d/phpfpm: fix readme and per process chart titles #7876

merged 6 commits into from
Jan 28, 2020

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Jan 28, 2020 •
edited
Loading

Summary

ssia

Fixes: #7868

Component Name

/collectors/python.d.plugin/phpfpm

Additional Information

@squash-labs
Copy link

squash-labs bot commented Jan 28, 2020

Manage this branch in Squash

Test this branch here: https://ilyam8phpfpm-docs-fix-wjpf5.squash.io

@ilyam8 ilyam8 mentioned this pull request Jan 28, 2020
Closed
thiagoftsm
thiagoftsm approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not run it, but the changes in the code should not create any bug.

@ilyam8 ilyam8 merged commit b466fbf into netdata:master Jan 28, 2020
@ilyam8 ilyam8 deleted the phpfpm_docs_fix branch January 28, 2020 16:01
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
@ilyam8 @Saruspete
collectors/python.d/phpfpm: fix readme and per process chart ti… (net…
f4b4071 
…data#7876)

* /collectors/python.d/phpfpm/README.md: update

* /collectors/python.d/phpfpm: update per process chart titles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelhans joelhans joelhans approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@cosmix cosmix Awaiting requested review from cosmix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

documentation on phpfpm plugin confusing
3 participants
@ilyam8 @joelhans @thiagoftsm