Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdata-updater.sh: explicitly return 0 from update #7955

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Feb 3, 2020

Summary

Fixes: #7954

If n is omitted, the return status is that of the last command executed in the function body.

It returns 1 when running on terminal.

We need return 0

else
# the installer updates this script - so we run and exit in a single line
update && exit 0
fi

Component Name

/packagin/installer

Additional Information

@squash-labs
Copy link

squash-labs bot commented Feb 3, 2020

Manage this branch in Squash

Test this branch here: https://ilyam8netdata-updater-fix-citxt.squash.io

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Feb 3, 2020
@ilyam8 ilyam8 merged commit 3522e07 into netdata:master Feb 3, 2020
@ilyam8 ilyam8 deleted the netdata_updater_fix branch February 3, 2020 09:54
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netdata-updater.sh: bug when running on terminal
3 participants