Fixes conditional for NetData Updater when checking for new updates

[gmeszaros]

This commit changes the check for updated releases when running in manual mode

Fixes #8027

Summary

This PR provides a quick fix for running manual updates.

Component Name

Netdata-updater

[squash-labs]

Manage this branch in Squash

Test this branch here: https://gmeszarosmanual-update-check-ibwci.squash.io

[claassistantio]

All committers have signed the CLA.

[ilyam8]

btw

first of all

netdata/packaging/installer/netdata-updater.sh

Line 141 in d3fa405

current_version="$(command -v netdata > /dev/null && parse_version "$(netdata -v | cut -f 2 -d ' ')")"

doesnt work because netdata is not in the PATH pretty often.

It means that following code

netdata/packaging/installer/netdata-updater.sh

Lines 147 to 148 in d3fa405

	if [ "${latest_version}" -gt 0 ] && [ "${current_version}" -gt 0 ] && [ "${current_version}" -ge "${current_version}" ]; then
	info "Newest version ${current_version} <= ${latest_version} is already installed"

doesnt work at all and only produces errors

./netdata-updater.sh: line 147: [: : integer expression expected

cc @Ferroin

[ilyam8]

@Ferroin do we even need this check

netdata/packaging/installer/netdata-updater.sh

Lines 147 to 148 in d3fa405

	if [ "${latest_version}" -gt 0 ] && [ "${current_version}" -gt 0 ] && [ "${current_version}" -ge "${current_version}" ]; then
	info "Newest version ${current_version} <= ${latest_version} is already installed"

?

[Ferroin]

@Ferroin do we even need this check

netdata/packaging/installer/netdata-updater.sh

Lines 147 to 148 in d3fa405

	if [ "${latest_version}" -gt 0 ] && [ "${current_version}" -gt 0 ] && [ "${current_version}" -ge "${current_version}" ]; then
	info "Newest version ${current_version} <= ${latest_version} is already installed"

?

I'm not sure.

Realistically, we should be checking the version like this instead of checking SHA256 hashes of the tarbals to determine if we need to upgrade or not, but we appear to have issues with that working when the user doesn't install in a way that netdata ends up in their path.

[ilyam8]

First check returns more detailed message and that is pretty much all. We do sha256 checking always anyway.

[prologic]

Test Plan:

Testing from master:

/netdata # /etc/periodic/daily/netdata-updater
Tue Feb 11 23:41:36 UTC 2020 : INFO:  Running on a terminal - (this script also supports running headless from crontab)
Tue Feb 11 23:41:37 UTC 2020 : INFO:  Current Version: 001019000482
Tue Feb 11 23:41:37 UTC 2020 : INFO:  Latest Version: 001019000481
Tue Feb 11 23:41:37 UTC 2020 : INFO:  Newest version 001019000482 <= 001019000481 is already installed

Testing from an older version:

/netdata # /etc/periodic/daily/netdata-updater
Tue Feb 11 23:50:45 UTC 2020 : INFO:  Running on a terminal - (this script also supports running headless from crontab)
Tue Feb 11 23:50:45 UTC 2020 : INFO:  Current Version: 001019000432
Tue Feb 11 23:50:45 UTC 2020 : INFO:  Latest Version: 001019000481
Tue Feb 11 23:50:45 UTC 2020 : INFO:  Newest version 001019000432 <= 001019000481 is already installed