-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes conditional for NetData Updater when checking for new updates #8028
Conversation
This commit changes the check for updated releases when running in manual mode
Manage this branch in SquashTest this branch here: https://gmeszarosmanual-update-check-ibwci.squash.io |
btw first of all
doesnt work because It means that following code netdata/packaging/installer/netdata-updater.sh Lines 147 to 148 in d3fa405
doesnt work at all and only produces errors
cc @Ferroin |
@Ferroin do we even need this check netdata/packaging/installer/netdata-updater.sh Lines 147 to 148 in d3fa405
? |
I'm not sure. Realistically, we should be checking the version like this instead of checking SHA256 hashes of the tarbals to determine if we need to upgrade or not, but we appear to have issues with that working when the user doesn't install in a way that |
First check returns more detailed message and that is pretty much all. We do sha256 checking always anyway. |
Test Plan: Testing from /netdata # /etc/periodic/daily/netdata-updater
Tue Feb 11 23:41:36 UTC 2020 : INFO: Running on a terminal - (this script also supports running headless from crontab)
Tue Feb 11 23:41:37 UTC 2020 : INFO: Current Version: 001019000482
Tue Feb 11 23:41:37 UTC 2020 : INFO: Latest Version: 001019000481
Tue Feb 11 23:41:37 UTC 2020 : INFO: Newest version 001019000482 <= 001019000481 is already installed Testing from an older version: /netdata # /etc/periodic/daily/netdata-updater
Tue Feb 11 23:50:45 UTC 2020 : INFO: Running on a terminal - (this script also supports running headless from crontab)
Tue Feb 11 23:50:45 UTC 2020 : INFO: Current Version: 001019000432
Tue Feb 11 23:50:45 UTC 2020 : INFO: Latest Version: 001019000481
Tue Feb 11 23:50:45 UTC 2020 : INFO: Newest version 001019000432 <= 001019000481 is already installed |
…etdata#8028) * Fix proposal for netdata#8027 This commit changes the check for updated releases when running in manual mode * Default (current|latest)_version to 0 and invert the logic Co-authored-by: James Mills <prologic@shortcircuit.net.au>
This commit changes the check for updated releases when running in manual mode
Fixes #8027
Summary
This PR provides a quick fix for running manual updates.
Component Name
Netdata-updater