Fix missing NETDATA_STOP_CMD in netdata-installer.sh

[prologic]

Summary

ssia

Component Name

• area/packaging

Test Plan

• Test on a SystemD system
• Test on macOS
• Test on FreeBSD
• Test on a SysV system
• Test on something non-standard

Additional Information

Looks like this was always missing in our packaging tooling :/

[squash-labs]

Manage this branch in Squash

Test this branch here: https://prologicfix-missing-stop-cmd-uh88j.squash.io

[prologic]

Tested on non-Standard systems (_plain 'ol install with no supervisor/init managing Netdata_):

$ ./netdata-installer.sh --dont-wait --dont-start-it --disable-go --install /tmp/netdata . . . To stop netdata run: /tmp/netdata/netdata/usr/sbin/netdatacli shutdown-agent To start netdata run: /tmp/netdata/netdata/usr/sbin/netdata . . .

[thiagoftsm]

@prologic shellcheck continues giving error:

          NETDATA_STOP_CMD="rc-service netdata stop"
          ^--------------^ SC2034: NETDATA_STOP_CMD appears unused. Verify use (or export if used externally).

[thiagoftsm]

Everything worked as expected on Slackware current, when you finish the work I will retest and approve it.

[prologic]

Tested on a SystemD system (_Debian Buster_):

$ sudo ./netdata-installer.sh --dont-wait --disable-go
.
.
.
To stop netdata run:

  systemctl stop netdata

To start netdata run:

  systemctl start netdata
.
.
.

[prologic]

Tested on FreeBSD:

root@freebsd:~/netdata # ./netdata-installer.sh --dont-wait --disable-go
.
.
.
To stop netdata run:

  service netdata stop

To start netdata run:

  service netdata start
.
.
.

[thiagoftsm]

I tested again on Slackware, and everything worked as expected!

[prologic]

Rebasing...