Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the exporting documentation #9066

Merged
merged 18 commits into from
May 18, 2020
Merged

Update the exporting documentation #9066

merged 18 commits into from
May 18, 2020

Conversation

vlvkobal
Copy link
Contributor

Summary

The documentation for the exporting engine was prepared for the upcoming release.

Part of #7015

Component Name

exporting engine

@vlvkobal vlvkobal requested a review from cosmix as a code owner May 15, 2020 20:36
@squash-labs
Copy link

squash-labs bot commented May 15, 2020

Manage this branch in Squash

Test this branch here: https://vlvkobalexporting-docs-cd93i.squash.io

thiagoftsm
thiagoftsm reviewed May 15, 2020
View reviewed changes
exporting/README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added area/exporting area/build Build system (autotools and cmake). area/docs labels May 15, 2020
thiagoftsm
thiagoftsm reviewed May 15, 2020
View reviewed changes
exporting/README.md Outdated Show resolved Hide resolved
ilyam8
ilyam8 reviewed May 16, 2020
View reviewed changes
exporting/README.md Outdated Show resolved Hide resolved
@vlvkobal vlvkobal requested a review from ktsaou as a code owner May 16, 2020 11:29
thiagoftsm
thiagoftsm approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the last commits, I think this PR is ready to be merged.

@thiagoftsm thiagoftsm requested a review from ilyam8 May 18, 2020 12:38
joelhans
joelhans approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@joelhans joelhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I have more that I want to do with this documentation before the 1.23 release goes out, but since that's more my work and not yours, I'm going to approve this and let you move on with other tasks! You'll hear more from me about the next phase of the docs soon!

@vlvkobal vlvkobal merged commit 06ffc8f into netdata:master May 18, 2020
@vlvkobal vlvkobal deleted the exporting-docs branch May 18, 2020 16:03
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
@vlvkobal @Saruspete
Update the exporting documentation (netdata#9066)
aa7ae59
@prologic prologic mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelhans joelhans joelhans approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@cosmix cosmix Awaiting requested review from cosmix

@ktsaou ktsaou Awaiting requested review from ktsaou

@ilyam8 ilyam8 Awaiting requested review from ilyam8

Assignees
No one assigned
Labels
area/build Build system (autotools and cmake). area/docs area/exporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vlvkobal @joelhans @ilyam8 @thiagoftsm